MyCoRe-SVN

Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
two open channels per call that are never closed. Once open you must consume the input as there are maybe MCRContent instances that are not #isReuseable() !

two open channels per call that are never closed. Once open you must consume the input as there are maybe MCRContent instances that are not #isReuseable() !

  • More
  • MCR-5
  • started review
MCR-1290 #comment Serving ranges from pdf now takes 30ms - 60ms on my mbp.
MCR-1290 #comment Serving ranges from pdf now takes 30ms - 60ms on my mbp.
            <span id="icon" class="glyphicon glyphicon-chevron-left" />             <span id="label">             <span id="icon" class="glyphicon glyphicon-chevron-right" />             <span id="...
            <span id="icon" class="glyphicon glyphicon-chevron-left" />
            <span id="label">
            <span id="icon" class="glyphicon glyphicon-chevron-right" />
            <span id="label">


"id" means document global unique. Consider making this a class or use a global unique id here.

  • More
  • MIR-2
  • started review
MIR-401 #comment rework pagination for browse
MIR-401 #comment rework pagination for browse
What about usage of Optional here? Optional.ofNullable(MCRContentTypes.probeContentType(mainDocumentPath)) .orElse("application/octect-stream");

What about usage of Optional here?

Optional.ofNullable(MCRContentTypes.probeContentType(mainDocumentPath))
    .orElse("application/octect-stream");
Use org.mycore.datamodel.niofs.MCRContentTypes.probeContentType(Path) so that we can inject our content type detectors

Use org.mycore.datamodel.niofs.MCRContentTypes.probeContentType(Path) so that we can inject our content type detectors

  • More
  • MCR-4
  • started review
MCR-1284 use MCRXMLFunctions.encodeURIPath to encode the path. Set probed content type or...
MCR-1284 use MCRXMLFunctions.encodeURIPath to encode the path. Set probed content type or...
URLEncoder ist nicht richtig hier. Er ist für Query-Parameter-Werte zuständig, nicht für URI-Pfade. Du kannst z.B. org.mycore.common.xml.MCRXMLFunctions.encodeURIPath(String) verwenden

URLEncoder ist nicht richtig hier. Er ist für Query-Parameter-Werte zuständig, nicht für URI-Pfade. Du kannst z.B. org.mycore.common.xml.MCRXMLFunctions.encodeURIPath(String) verwenden

  • More
  • MCR-3
  • started review
MCR-1284 #comment encode maindoc
MCR-1284 #comment encode maindoc
We should try to implement multiple layouts inside the grunt file. I will try to implement something after mycore release is ready.

We should try to implement multiple layouts inside the grunt file. I will try to implement something after mycore release is ready.

Ich brauche hier eine Möglichkeit um den Vorgang mehrfach laufen zu lassen für jede Layout-Variante. Zum Testen habe ich jetzt erstmal zwei drin: "flatmir" und "noa". Wenn ich nun "mvn install" ein...

Ich brauche hier eine Möglichkeit um den Vorgang mehrfach laufen zu lassen für jede Layout-Variante. Zum Testen habe ich jetzt erstmal zwei drin: "flatmir" und "noa". Wenn ich nun "mvn install" einmal mit "flatmir" und danach (ohne "clean") mit noa laufen lasse, habe ich das gewünschte Ergebnis und kann dann durch Setzen des neuen properties MIR.Layout.Theme das Layout in der Anwendung ändern.

Hast du eine Idee?

  • More
  • MIR-1
  • started review
MIR-63 #comment set flatmir as default
MIR-63 #comment set flatmir as default
changed like recommended

changed like recommended

  • More
  • MCR-1
  • started review
MCR-877 #comment use SOLR to filter empty categories in classifications
MCR-877 #comment use SOLR to filter empty categories in classifications
            solrQquery.setQuery("category:\"" + classId + ":" + cat.getAttributeValue("ID") + "\""); You should use org.mycore.solr.MCRSolrUtils.escapeSearchValue(String) here to escape any specia...
            solrQquery.setQuery("category:\"" + classId + ":" + cat.getAttributeValue("ID") + "\"");

You should use org.mycore.solr.MCRSolrUtils.escapeSearchValue(String) here to escape any special character that may be present in the value